Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix Updates #2095

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Nix Updates #2095

merged 7 commits into from
Jan 27, 2025

Conversation

Lorwp
Copy link
Contributor

@Lorwp Lorwp commented Jan 22, 2025 •
edited by Cyberboss
Loading

🆑
Nix: Source our configuration file directly as a path instead of using a string to define it.
Nix: Set reloadTriggers in the configured systemd service unit to reload when the TGS configuration is changed.
Nix: Set restartIfChanged so we don't keep restarting tgstation-server.service whenever it gets touched in the slightest.
Nix: Set after to depend on relevant DBs TGS uses.
/🆑

Nix Infra related stuff.

@Lorwp Lorwp requested a review from Cyberboss as a code owner January 22, 2025 23:27
@Lorwp Lorwp changed the title Cyberboss patch 1 Nix Updates Jan 22, 2025
@tgstation-server-ci tgstation-server-ci
Copy link
Contributor

Thank you for contributing to tgstation-server! The workflow 'CI Gated PR Comments' requires repository secrets and will not run without approval. Maintainers can add the CI Cleared label to allow it to run. Note that any changes to ci-security.yml and ci-pipeline.yml will not be reflected.

@tgstation-server-ci tgstation-server-ci bot added size/S CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution labels Jan 22, 2025
@tgstation-server-ci tgstation-server-ci bot added CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution and removed CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution labels Jan 22, 2025
@Cyberboss Cyberboss added this to the v6.12.4 milestone Jan 22, 2025
Cyberboss
Cyberboss requested changes Jan 25, 2025
View reviewed changes
Copy link
Member

@Cyberboss Cyberboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add After sections for the various DB types like in ./build/tgstation-server.service please

@tgstation-server-ci tgstation-server-ci bot added CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution and removed CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution labels Jan 25, 2025
@Lorwp Lorwp requested a review from Cyberboss January 25, 2025 23:24
@Cyberboss Cyberboss added the CI Cleared Apply this to a pull request from a fork to allow it to run the CI suite label Jan 26, 2025
@tgstation-server-ci tgstation-server-ci bot removed the CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution label Jan 26, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@73abb5b). Learn more about missing BASE report.
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2095   +/-   ##
=========================================
  Coverage          ?   95.64%           
=========================================
  Files             ?      811           
  Lines             ?   175253           
  Branches          ?     3555           
=========================================
  Hits              ?   167617           
  Misses            ?     7066           
  Partials          ?      570

@tgstation-server-ci tgstation-server-ci bot added CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution and removed CI Cleared Apply this to a pull request from a fork to allow it to run the CI suite labels Jan 26, 2025
@Cyberboss Cyberboss added the CI Cleared Apply this to a pull request from a fork to allow it to run the CI suite label Jan 27, 2025
@Cyberboss Cyberboss enabled auto-merge January 27, 2025 00:14
@tgstation-server-ci tgstation-server-ci bot removed the CI Approval Required CI Pipeline execution blocked. Maintainers, apply the "CI Cleared" label to allow execution label Jan 27, 2025
@Cyberboss Cyberboss added the CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION label Jan 27, 2025
@Cyberboss Cyberboss merged commit 4e24216 into tgstation:master Jan 27, 2025
77 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyberboss Cyberboss Cyberboss approved these changes

Assignees
No one assigned
Labels
CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION CI Cleared Apply this to a pull request from a fork to allow it to run the CI suite size/S
Projects
None yet
Milestone
v6.12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Lorwp @Cyberboss